Add textdomain to fix untranslated error messages
#925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
force-pushed
the
missing-textdomain
branch
2 times, most recently
from
d4926ff
to
049c88c
Compare
mvidner
force-pushed
the
missing-textdomain
branch
2 times, most recently
from
b644898
to
344a61c
Compare
jreidinger
approved these changes
Jul 25, 2019
mvidner
force-pushed
the
missing-textdomain
branch
from
344a61c
to
36dd565
Compare
… (bsc#1130822) add missing 'textdomain' call
"Format System Volumes", "/etc/fstab found on /dev/sda1 contains:"
mvidner
force-pushed
the
missing-textdomain
branch
from
36dd565
to
df0679a
Compare
|
✔️ Public Jenkins job #333 successfully finished |
|
✔️ Internal Jenkins job #130 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
textdomaindeclaration is per class which means there were several cases of having several classes in a file and only one of them declaring the text domain.Also added detecting a missing textdomain during unit testing (using yast/yast-ruby-bindings#230).